frontend/components/tests/CookieBanner.test.tsx (3)

1-3: Consider adding @testing-library/jest-dom for better assertions.

The test uses toBeDefined() and toBeNull() which work but are less expressive than jest-dom matchers like toBeInTheDocument(). Adding @testing-library/jest-dom provides more semantic DOM assertions.

♻️ Recommended setup

1. Install the package:

npm install -D @testing-library/jest-dom

2. Create a setup file (e.g., vitest.setup.ts):

import '@testing-library/jest-dom/vitest';

3. Update vitest.config.ts:

test: {
  environment: 'jsdom',
  setupFiles: ['./vitest.setup.ts'],
  // ...
}

---

29-38: Strengthen assertions with more specific matchers.

toBeDefined() passes for any truthy value. Consider using toBeInTheDocument() (with jest-dom) or at minimum check the element content/role for stronger validation.

♻️ Suggested improvement

-    expect(screen.getByText('title')).toBeDefined();
+    expect(screen.getByText('title')).toBeVisible();

Or without jest-dom:

-    expect(screen.getByText('title')).toBeDefined();
+    const titleElement = screen.getByText('title');
+    expect(titleElement).toBeTruthy();
+    expect(titleElement.textContent).toBe('title');

---

40-52: Good test coverage for the accept flow.

The test properly verifies both the localStorage side effect and the UI state change after clicking accept.

Consider adding a test for the decline button to ensure complete coverage of the CookieBanner's interactive behavior.

📝 Additional test case suggestion

it('Click Decline -> Saves to LocalStorage -> Hides Banner', () => {
  render(<CookieBanner />);

  act(() => {
    vi.advanceTimersByTime(500);
  });

  const declineButton = screen.getByText('decline');
  fireEvent.click(declineButton);

  expect(localStorage.getItem('cookie-consent')).toBe('declined');
  expect(screen.queryByText('title')).toBeNull();
});

frontend/drizzle/0014_steep_kabuki.sql (1)

1-3: Verify no orphaned user_id records exist before migration.

Adding a foreign key constraint will fail if quiz_attempts.user_id contains values that don't exist in users.id. Ensure data integrity before running this migration in production.

Run this query against your database before applying the migration:

SELECT DISTINCT qa.user_id 
FROM quiz_attempts qa 
LEFT JOIN users u ON qa.user_id = u.id 
WHERE u.id IS NULL;

If any rows are returned, either:

1. Delete the orphaned records, or
2. Create placeholder user records

Also consider running the migration during low-traffic periods as creating indexes on large tables can lock the table temporarily.

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Learnt from: kryvosheyin
Repo: DevLoversTeam/devlovers.net PR: 88
File: frontend/drizzle/schema.ts:153-153
Timestamp: 2025-12-30T16:01:02.523Z
Learning: The file frontend/drizzle/schema.ts is a legacy file not used by Drizzle or the runtime. The canonical schemas live in frontend/db/schema/* as configured in drizzle-config.ts, and that's what migrations and runtime use.